Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance markdown preview for backlinks #8956

Merged
merged 1 commit into from
Dec 2, 2024
Merged

feat: enhance markdown preview for backlinks #8956

merged 1 commit into from
Dec 2, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Nov 28, 2024 •
edited
Loading

fix AF-1770
fix AF-1771

fix: doc link middlewares
feat: markdown renderer
feat: allow multiple backlink for a single doc
feat: showing correct doc ref link
feat: trim long para & ident lists
feat: list indentition fix
feat: database/latext handling
feat: other block types handling
fix: lint

@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 28, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@pengx17 Graphite App
Copy link
Collaborator Author

pengx17 commented Nov 28, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pengx17 pengx17 marked this pull request as ready for review November 28, 2024 09:32
@pengx17 pengx17 mentioned this pull request Nov 28, 2024
Merged
@pengx17 pengx17 changed the title fix: doc link middlewares feat: enhance markdown preview for backlinks Nov 28, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 28, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 31bab25. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 64.67%. Comparing base (b8467a9) to head (31bab25).
Report is 2 commits behind head on canary.

Files with missing lines Patch % Lines
...ksuite/presets/_common/components/text-renderer.ts 0.00% 7 Missing ⚠️
...blocksuite/presets/_common/utils/markdown-utils.ts 0.00% 3 Missing ⚠️
.../src/blocksuite/presets/ai/utils/editor-actions.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           canary    #8956      +/-   ##
==========================================
- Coverage   64.68%   64.67%   -0.01%     
==========================================
  Files         664      664              
  Lines       37344    37349       +5     
  Branches     3611     3614       +3     
==========================================
  Hits        24156    24156              
- Misses      12820    12825       +5     
  Partials      368      368
Flag Coverage Δ
server-test 77.07% <ø> (ø)
unittest 34.55% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 mentioned this pull request Nov 28, 2024
Merged
@github-actions github-actions bot added the test Related to test cases label Nov 28, 2024
@pengx17 pengx17 force-pushed the xp/indexer/markdown-preview-enhance branch from b5ce9ea to 22dd7ab Compare November 28, 2024 10:20
@pengx17 pengx17 force-pushed the xp/indexer/markdown-preview-enhance branch from 22dd7ab to 4582200 Compare November 28, 2024 11:23
@EYHN EYHN force-pushed the xp/indexer/markdown-preview-enhance branch from c17f903 to 5b512f9 Compare December 2, 2024 03:57
@pengx17 pengx17 force-pushed the xp/indexer/markdown-preview-enhance branch from 5b512f9 to ce125c8 Compare December 2, 2024 04:31
@pengx17 pengx17 force-pushed the xp/indexer/markdown-preview-enhance branch from ce125c8 to 637a897 Compare December 2, 2024 07:59
@pengx17 pengx17 force-pushed the xp/indexer/markdown-preview-enhance branch from 637a897 to 50716da Compare December 2, 2024 10:15
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 2, 2024 •
edited
Loading

Merge activity

@pengx17
feat: enhance markdown preview for backlinks (#8956)
31bab25 
fix AF-1770
fix AF-1771

---

fix: doc link middlewares
feat: markdown renderer
feat: allow multiple backlink for a single doc
feat: showing correct doc ref link
feat: trim long para & ident lists
feat: list indentition fix
feat: database/latext handling
feat: other block types handling
fix: lint
@pengx17 pengx17 force-pushed the xp/indexer/markdown-preview-enhance branch from 50716da to 31bab25 Compare December 2, 2024 10:29
@graphite-app graphite-app bot merged commit 31bab25 into canary Dec 2, 2024
46 checks passed
@graphite-app graphite-app bot deleted the xp/indexer/markdown-preview-enhance branch December 2, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@EYHN EYHN EYHN approved these changes

@JimmFly JimmFly Awaiting requested review from JimmFly

@CatsJuice CatsJuice Awaiting requested review from CatsJuice

@forehalo forehalo Awaiting requested review from forehalo

Assignees
No one assigned
Labels
app:core mod:component mod:i18n Related to i18n test Related to test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pengx17 @EYHN